Re: Rgeression: 2.6.30-rc6-git3 build error - ICE from drivers/char/random.c

[Martin Knoblauch]

----- Original Message ----

> From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> To: Martin Knoblauch <spamtrap@xxxxxxxxxxxx>
> Cc: Matt Mackall <mpm@xxxxxxxxxxx>; Ingo Molnar <mingo@xxxxxxx>; Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>
> Sent: Tuesday, May 19, 2009 8:24:48 PM
> Subject: Re: Rgeression: 2.6.30-rc6-git3 build error - ICE from drivers/char/random.c
> 
> 
> 
> On Tue, 19 May 2009, Linus Torvalds wrote:
> > 
> > I guess getting rid of 'jiffies' is also worth it. Even at its very worst, 
> > 'get_cycles()' should return jiffy-level information, so adding in jiffies 
> > doesn't add anything to it.
> 
> I take that back. If there isno TSC at all, "get_cycles()" might just be 
> returning zero. So the jiffies fallback is probably better than nothing.
> 
> So I'll just remove the (long)&ret part. And you already said that that 
> fixed it both with my previous patch and without, so I guess it's already 
> tested.
> 
>         Linus

 correct. The original code with  (long)&ret removed yields:

        hash[0] += current->pid + jiffies + get_cycles();

and compiles OK.

Tested-by: Martin Knoblauch <spamtrap@xxxxxxxxxxxx>

Cheers
Martin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/