Re: [git-pull -tip] x86: Addition of cpufeatures to friendlyaccess miscellaneous MSRs

[Jaswinder Singh Rajput]

On Mon, 2009-05-11 at 11:15 -0700, H. Peter Anvin wrote:
> Jaswinder Singh Rajput wrote:
> > 
> > Jaswinder Singh Rajput (15):
> >       x86: Add cpufeature for Processor Name
> >       x86: Add cpufeatures for Advanced Power Management
> >       x86: Add cpufeature for Microcode update
> >       x86: Add cpufeature for Cache MSRs
> >       x86: Add cpufeature for Hard and Soft Poweron configuration
> >       x86: Add cpufeature for Scaleable bus speed
> >       x86: Add cpufeature for Miscellaneous Features
> >       x86: Add cpufeature for Platform feature
> >       x86: Add cpufeature for Hardware configuration
> >       x86: Add cpufeature for System configuration
> >       x86: Add cpufeature for System management mode (SMM)
> >       x86: Add cpufeature for MM configuration
> >       x86: Add cpufeature for Bus configuration
> >       x86: Add cpufeature for performance frequency APERF/MPERF
> >       x86: Add cpufeature for ancient performance monitoring
> > 
> 
> Overall, I'm rather confused what the point of this is supposed to be. 
> There is value to centralizing CPU knowledge, but some of these flags 
> are only used in one place, and as far as I can see in several of your 
> patches they aren't used *at all*.
> 
> If there is no in-kernel user there is absolutely no point to this.
> 

The basic point of these patchset is to friendly access miscellaneous
MSRs in kernel and userspace.

Some of these patches are using hardware cpufeature and others are
software.

In kernel some of these MSRs are frequently used and doing checking
before accessing these MSR in various places.

So I think it will be right approach to check in one place and set
related cpufeature and in other places we only need to check cpufeature
and then access MSR.

This patchset is only adding cpufeature. I will release accessing
cpufeatures in upcoming series.

--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/