Re: [PATCH 3/5] tracing/events: add rcu locking around trace eventprints

[Steven Rostedt]

On Fri, 17 Apr 2009, Jeremy Fitzhardinge wrote:

> Theodore Tso wrote:
> > I haven't been following all of the e-mail threads about the include
> > hell problem; what are the issues, exactly?  What's the problem with
> > simply including <linux/rcuupdate.h>, and any needed prequisites in
> > ftrace.h?
> 
> I'm adding tracing support to paravirt.h, which in turn gets included in
> various low-level arch/x86 headers.  If it starts including other high-level
> linux/ headers, we quickly get into deep #include recursion problems and
> undefined symbols.

I think our final solution of the:

#ifdef CREATE_FOO_TRACE_POINTS
#undef CREATE_FOO_TRACE_POINTS
#include <trace/define_trace.h>
#endif

would fix this for us.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/