Re: netrom: zero length frame filtering in NetRom

[Alan Cox]

On Fri, 27 Mar 2009 14:34:06 -0700 (PDT)
David Miller <davem@xxxxxxxxxxxxx> wrote:

> From: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
> Date: Fri, 27 Mar 2009 10:28:23 +0000
> 
> > 
> > > +	/* NetRom empty data frame has no meaning : ignore it */
> > > +	if (copied == 0) {
> > > +		goto out;
> > > +	}
> > > +
> > 
> > Also broken - and doesn't follow the coding style either 8)
> 
> Well, you send these turds to me and you're usually knowledgable
> in the amateur radio protocol area :-)
> 
> I'll back them both out which is what I assume you want me to
> do.

Yes. Handling zero length frames with socket API is nasty and ugly but
unfortunately its a valid use of these protocols. I need to go read the
AF_ROSE docs to double check the situation with ROSE but the other two
definitely want backing out.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/