Re: [PATCH] btrfs: fix __ucmpdi2 compile bug on 32 bit builds

[Stephen Rothwell]

Hi Heiko,

On Fri, 27 Mar 2009 13:42:52 +0100 Heiko Carstens <heiko.carstens@xxxxxxxxxx> wrote:
>
\> @@ -2884,25 +2884,19 @@ int extent_fiemap(struct inode *inode, s
>  		disko = 0;
>  		flags = 0;
>  
> -		switch (em->block_start) {
> -		case EXTENT_MAP_LAST_BYTE:
> +		if (em->block_start == EXTENT_MAP_LAST_BYTE) {

I might be a good idea to put a comment there about why this isn't a
switch statement so that someone doesn't "clean up" this code in the
future.

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature