Re: [PATCH -tip] x86: unification of module.c

[Ingo Molnar]

* Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:

> On Thu, 26 Mar 2009, Jaswinder Singh Rajput wrote:
> > This patch is based on -tip:x86/core:
> > 
> > From: Jaswinder Singh Rajput <jaswinderrajput@xxxxxxxxx>
> > Date: Thu, 26 Mar 2009 18:33:45 +0530
> > Subject: [PATCH] x86: unification of module.c
> > 
> > Impact: Unification, cleanup
> > 
> > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@xxxxxxxxx>
> > ---
> >  arch/x86/kernel/Makefile    |    2 +-
> >  arch/x86/kernel/module.c    |  261 +++++++++++++++++++++++++++++++++++++++++++
> >  arch/x86/kernel/module_32.c |  152 -------------------------
> >  arch/x86/kernel/module_64.c |  194 --------------------------------
> >  4 files changed, 262 insertions(+), 347 deletions(-)
> >  create mode 100644 arch/x86/kernel/module.c
> >  delete mode 100644 arch/x86/kernel/module_32.c
> >  delete mode 100644 arch/x86/kernel/module_64.c
> 
> Sigh. We went through this before.
> 
> First make module_32 and module_64 the same if necessary in 
> several steps. The last step is to rename one of the files to 
> module.c and remove the other one.
> 
> This cobble all together approach is hard to review and error 
> prone.

Correct. There are countless examples of properly structured and 
well executed unifications in the arch/x86 tree.

The most recent one has been done by Gustavo F. Padovan - and this 
was one of this first complex contributions to Linux:

 c577b09: x86, fixmap: unify fixmap.h
 c78f322: x86, fixmap: prepare fixmap_32.h for unification
 e365bcd: x86, fixmap: prepare fixmap_64.h for unification
 5f403fa: x86, fixmap: add CONFIG_EFI
 2ae38da: x86, fixmap: add CONFIG_X86_{LOCAL,IO}_APIC
 fd862dd: x86, fixmap: define reserve_top_address for x86_64
 ab93e3c: x86, fixmap: define FIXADDR_BOOT_* and redefine FIX_ADDR_SIZE
 d09375a: x86, fixmap: rename __FIXADDR_SIZE and __FIXADDR_BOOT_SIZE

Please use this as a template - all-in-one patches for unifications 
are not reviewable, not testable and not acceptable.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/