Re: [PATCH -tip] x86: unification of module.c

[Thomas Gleixner]

On Thu, 26 Mar 2009, Jaswinder Singh Rajput wrote:
> This patch is based on -tip:x86/core:
> 
> From: Jaswinder Singh Rajput <jaswinderrajput@xxxxxxxxx>
> Date: Thu, 26 Mar 2009 18:33:45 +0530
> Subject: [PATCH] x86: unification of module.c
> 
> Impact: Unification, cleanup
> 
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@xxxxxxxxx>
> ---
>  arch/x86/kernel/Makefile    |    2 +-
>  arch/x86/kernel/module.c    |  261 +++++++++++++++++++++++++++++++++++++++++++
>  arch/x86/kernel/module_32.c |  152 -------------------------
>  arch/x86/kernel/module_64.c |  194 --------------------------------
>  4 files changed, 262 insertions(+), 347 deletions(-)
>  create mode 100644 arch/x86/kernel/module.c
>  delete mode 100644 arch/x86/kernel/module_32.c
>  delete mode 100644 arch/x86/kernel/module_64.c

Sigh. We went through this before. 

First make module_32 and module_64 the same if necessary in several
steps. The last step is to rename one of the files to module.c and
remove the other one.

This cobble all together approach is hard to review and error prone.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/