Re: USB: symbolserial: log the ioctl commands

[Alan Cox]

> +static int symbol_tiocmget(struct tty_struct *tty, struct file *file)
> +{
> +	struct usb_serial_port *port = tty->driver_data;
> +	struct device *dev = &port->dev;
> +
> +	/* TODO */
> +	/* probably just need to shadow whatever was sent to us here */
> +	dev_info(dev, "%s\n", __func__);
> +	return 0;
> +}

If you don't have a modem you don't provide these methods. If you do have
a modem you return the values for the modem. Please do not try and stick
in stuff faking responses, it just makes a nasty mess in the longer term
and I've already cleared the same out of a ton of drivers - with I note
no breakages of user space.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/