Re: USB: serial: add symbol serial driver

[Alan Cox]

On Thu, 26 Mar 2009 19:29:28 GMT
Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx> wrote:

Thank you for not running this past the tty layer maintainer.


> +	/*
> +	 * Force low_latency on so that our tty_push actually forces the data
> +	 * through, otherwise it is scheduled, and with high data rates (like
> +	 * with OHCI) data can get lost.
> +	 */
> +	if (tty)
> +		tty->low_latency = 1;

The above is bogus cargo cult programming copied from old drivers and
should be removed.



Otherwise looks fine
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/