Re: [PATCH 5/6] perf_counter: kerneltop: mmap_pages argument

[Peter Zijlstra]

On Wed, 2009-03-25 at 13:54 +0100, Ingo Molnar wrote:
> * Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> wrote:
> 
> > On Wed, 2009-03-25 at 13:35 +0100, Ingo Molnar wrote:
> > 
> > > > Also, when mixing streams (events,mmap) is a single: you missed 
> > > > 'n' events still good?
> > > 
> > > How would such mixing work? Multiple counters streaming into the 
> > > same mmap area?
> > 
> > No basically having overflow events and mmap-vma changed events in 
> > a single output stream.
> 
> ah, and i missed the impact of variable size records - that too 
> makes it somewhat impractical to emit overflow records in situ. (the 
> kernel does not really know the precise start of the previous 
> record, typically.)

Alternatively, we could simply not emit new events until the read
position increases,. that's much simpler.

Still don't like mapping the stuff writable though..

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/