Re: [PATCH 06/13] [scsi] changed ioctls to unlocked

From: Matthew Wilcox
Date: Wed Mar 25 2009 - 00:21:39 EST


On Tue, Mar 24, 2009 at 04:12:41PM -0500, stoyboyker@xxxxxxxxx wrote:
> +static long osst_ioctl(struct file * file, unsigned int cmd_in,
> + unsigned long arg)
> {
> + lock_kernel();
> int i, cmd_nr, cmd_type, blk, retval = 0;

Did you try compiling this? If so, what compiler did you use? You
*should* have got an error about mixing code and declarations.

--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/