Re: ftrace not working?

From: Steven Rostedt
Date: Wed Mar 25 2009 - 00:19:28 EST





On Wed, 25 Mar 2009, Nikanth Karthikesan wrote:

> On Wednesday 25 March 2009 07:51:34 Steven Rostedt wrote:
> > On Tue, 24 Mar 2009, Frederic Weisbecker wrote:
> > > > Steve, Can you merge this.
> > > >
> > > > Thanks
> > > > Nikanth
> > > >
> > > > In tracer_alloc_buffers(), do not free tracing_cpumask and
> > > > tracing_buffer_mask on success.
> > > >
> > > > Signed-off-by: Nikanth Karthikesan <knikanth@xxxxxxx>
> > > >
> > > > ---
> > > >
> > > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> > > > index 17bb88d..98f609d 100644
> > > > --- a/kernel/trace/trace.c
> > > > +++ b/kernel/trace/trace.c
> > > > @@ -3887,6 +3887,7 @@ __init static int tracer_alloc_buffers(void)
> > > >
> > > > register_die_notifier(&trace_die_notifier);
> > > > ret = 0;
> > > > + goto out;
> > >
> > > Ah I see.
> > > I've sent a fix for that already, it's on latest -tip
> > > http://git.kernel.org/?p=linux/kernel/git/tip/linux-2.6-tip.git;a=commit;
> > >h=2fc1dfbe17e7705c55b7a99da995fa565e26f151
> >
> > Nikanth,
> >
> > Could you varify that tip is not an issue for you.
> >
> > http://people.redhat.com/~mingo/tip.git/readme.txt
> >
>
> Oh. That should fix it. It would be nice to have it in stable 2.6.29.1.

When it is pulled into Linus's tree, I'll send an note to Greg asking him
to include it into stable.

Thanks,

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/