Re: [PATCH] kernel/irq: fix sparse warning: make symbol static

[Ingo Molnar]

* Matthew Wilcox <matthew@xxxxxx> wrote:

> On Sun, Feb 08, 2009 at 08:24:47PM +0100, Hannes Eder wrote:
> > -static inline int do_irq_select_affinity(int irq, struct irq_desc *desc)
> > +static inline int do_irq_select_affinity(unsigned int irq, struct irq_desc *desc)
> 
> Does this not introduce a checkpatch warning about a line being longer
> than 80 columns?  Three acceptable ways to fix this:

It does - 81 cols. We could ignore it (it's close enough to the limit), but:

> static inline
> int do_irq_select_affinity(unsigned int irq, struct irq_desc *desc)
> 
> static inline int do_irq_select_affinity(unsigned int irq,
> 							struct irq_desc *desc)
> 
> static inline int do_irq_select_affinity(unsigned irq, struct irq_desc *desc)
> 
> My favourite is the last one.

I went for the fourth way which is even better - see the commit below ;-)

Applied to tip/irq/urgent, thanks guys!

	Ingo

----------------->