Re: [PATCH] kernel/irq: fix sparse warning: make symbol static

From: Matthew Wilcox
Date: Sun Feb 08 2009 - 18:10:06 EST


On Sun, Feb 08, 2009 at 08:24:47PM +0100, Hannes Eder wrote:
> -static inline int do_irq_select_affinity(int irq, struct irq_desc *desc)
> +static inline int do_irq_select_affinity(unsigned int irq, struct irq_desc *desc)

Does this not introduce a checkpatch warning about a line being longer
than 80 columns? Three acceptable ways to fix this:

static inline
int do_irq_select_affinity(unsigned int irq, struct irq_desc *desc)

static inline int do_irq_select_affinity(unsigned int irq,
struct irq_desc *desc)

static inline int do_irq_select_affinity(unsigned irq, struct irq_desc *desc)

My favourite is the last one.

--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/