Re: [PATCH 1/3] tracing/ftrace: don't insert TRACE_PRINT during selftests

[Frédéric Weisbecker]

2008/12/5 Ingo Molnar <mingo@xxxxxxx>:
>
> * Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:
>
>> Impact: fix tracer selfstests false results
>>
>> After setting a ftrace_printk somewhere in th kernel, I saw the
>> Function tracer selftest failing.
>>
>> When a selftest occurs, the ring buffer is lurked to see if
>> some entries were inserted. But concurrent insertion such as
>> ftrace_printk could occured at the same time and could give
>> false positive or negative results.
>>
>> This patch prevent prevent from TRACE_PRINT entries insertion
>> during selftests.
>>
>> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
>> ---
>>  kernel/trace/trace.c |   13 ++++++++++++-
>>  1 files changed, 12 insertions(+), 1 deletions(-)
>
> applied to tip/tracing/ftrace, thanks.
>
> I suspect you'll also fix the things Steve pointed out?


Yes of course :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/