Re: 2.6.27-rc1: softcursor behaviour changed

From: Stefano Stabellini
Date: Thu Aug 07 2008 - 08:54:56 EST


Pavel Machek wrote:

> Hi!
>
>> In 2.6.26, this
>>
>> echo -e "\33[10;5000]\33[11;50]\33[?18;0;136c\33[?102m"
>>
>> produces some variation on cursor. on 2.6.27-rc1, I have no cursor at
>> all :-(.
>
> The patch that changed it is below... and I must say I liked the old
> behaviour better. Unlike blinking, high-brightness background is
> actually useful. Can we get that one reverted?


The problem is not a matter of taste but a matter of correctness: the
build_attr function in drivers/char/vt.c stores the blink attribute as
the forth bit of the background color.
Then in fbcon we are interpreting the same forth bit of the background
color as intensity bit.
My patch fixes that.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/