Re: [PATCH] x86, acpi: temp_stack is used only when CONFIG_SMP isset

[Marcin Slusarz]

On Sun, Aug 03, 2008 at 07:07:30PM +0200, Sven Wegener wrote:
> On Sun, 3 Aug 2008, Marcin Slusarz wrote:
> 
> > arch/x86/kernel/acpi/sleep.c:24: warning: 'temp_stack' defined but not used
> > 
> > Signed-off-by: Marcin Slusarz <marcin.slusarz@xxxxxxxxx>
> > Cc: Glauber Costa <gcosta@xxxxxxxxxx>
> > Cc: Pavel Machek <pavel@xxxxxxx>
> > Cc: Ingo Molnar <mingo@xxxxxxx>
> > ---
> >  arch/x86/kernel/acpi/sleep.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/x86/kernel/acpi/sleep.c b/arch/x86/kernel/acpi/sleep.c
> > index fa2161d..9103cb6 100644
> > --- a/arch/x86/kernel/acpi/sleep.c
> > +++ b/arch/x86/kernel/acpi/sleep.c
> > @@ -20,7 +20,7 @@ unsigned long acpi_realmode_flags;
> >  /* address in low memory of the wakeup routine. */
> >  static unsigned long acpi_realmode;
> >  
> > -#ifdef CONFIG_64BIT
> > +#ifdef CONFIG_SMP
> >  static char temp_stack[10240];
> >  #endif
> >  
> 
> Now it still generates the warning, but on i386 with CONFIG_SMP set, 
> instead of x86_64 without CONFIG_SMP. We only need temp_stack, when both 
> CONFIG_64BIT and CONFIG_SMP are activated.

Yes. Thanks for looking at the patch!

---