Re: [patch 06/15] MMC: Add platform data for S3C24XX MMC/SD driver

From: Pierre Ossman
Date: Sat Jun 14 2008 - 12:23:16 EST


On Fri, 06 Jun 2008 16:51:23 +0100
Ben Dooks <ben-linux@xxxxxxxxx> wrote:

> This patch adds platform data support to the s3mci driver. This allows
> flexible board-specific configuration of set_power, card detect and read only
> pins.
>
> Signed-off-by: Ben Dooks <ben-linux@xxxxxxxxx>
>

Please see the changes in my #next branch where you can return -ENOSYS
to indicate that you do not know the state of the read only pin.

> +
> +static struct s3c24xx_mci_pdata s3cmci_def_pdata = {
> + .gpio_detect = 0,
> + .set_power = NULL,
> + .ocr_avail = MMC_VDD_32_33,
> };

You probably want MMC_VDD_32_32 | MMC_VDD_33_34 here.

Attachment: signature.asc
Description: PGP signature