Re: [patch 05/15] MMC: Fix S3C24XX IRQ enable during PIO transfersFrom: Roman Moracik <roman.moravcik@gmail.com>

[Pierre Ossman]

On Fri, 06 Jun 2008 16:51:22 +0100
Ben Dooks <ben-linux@xxxxxxxxx> wrote:

> Fix Bug #677 - I/O errors on heavy microSD writes for 2.6.22.x.
> 
> Signed-off-by: Ben Dooks <ben-linux@xxxxxxxxx>
> 
> Index: linux-2.6.26-rc5-q/drivers/mmc/host/s3cmci.c
> ===================================================================
> --- linux-2.6.26-rc5-q.orig/drivers/mmc/host/s3cmci.c	2008-06-06 15:46:01.000000000 +0100
> +++ linux-2.6.26-rc5-q/drivers/mmc/host/s3cmci.c	2008-06-06 15:46:03.000000000 +0100
> @@ -313,6 +313,7 @@ static void pio_tasklet(unsigned long da
>  {
>  	struct s3cmci_host *host = (struct s3cmci_host *) data;
>  
> +	disable_irq(host->irq);
>  

This seems harsh. Can't you just fiddle with the interrupt mask of this
specific device?

Attachment: signature.asc
Description: PGP signature