Re: [PATCH -mm 11/24] pageflag helpers for configed-out flags

[Lee Schermerhorn]

On Wed, 2008-06-11 at 13:01 -0700, Andrew Morton wrote:
> On Wed, 11 Jun 2008 14:42:25 -0400
> Rik van Riel <riel@xxxxxxxxxx> wrote:
> 
> > Define proper false/noop inline functions for noreclaim page
> > flags when !defined(CONFIG_NORECLAIM_LRU)
> 
> I changed that to CONFIG_UNEVICTABLE_LRU.

I noticed that the vmstat items [perhaps these will go away] still use
"noreclaim".

> 
> Did we agree that the presence of this config variable is undesirable? 

Not sure we did.  It does add quite a bit of code that probably wouldn't
be needed/wanted for, say, a laptop system or other small systems that
still have an mmu.  I initially made it configurable keeping in mind
your speeches about not burdening smaller systems with larger system
features, ...  

> If so, what's involved in making it go away?

Just some busy work.  I added a fair number of wrappers and such to
minimize #ifdefs in the .c files.  This resulted in quite a few such
#ifdefs in the respective headers.   Removing these should mostly
involve removing the #ifdef and the #else case.  Most of them that
remain in .c files are for large blocks of code, mostly complete
functions, and can just be removed.

Let me know the consensus.  I can send in a patch to remove them if it's
agreed.  Might want to wait until we're sure that this is the only
barrier to merging, as the option might be useful during testing. 

Lee


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/