Re: mconf.c and bindtextdomain() -- warnings while cross-compiling on OS X

From: Sam Ravnborg
Date: Sun May 04 2008 - 15:07:51 EST


On Sun, May 04, 2008 at 01:42:34PM -0500, Timur Tabi wrote:
> Sam Ravnborg wrote:
>
> >I have queued up following patch. It is obviously correct and builds
> >without
> >warnings here. Can you give it a try on your box.
>
> ...
>
> >+static inline void const char *gettext(const char *txt) { return txt; }
>
> Drop the "void" on this line and this patch works.
>
> While you're at it, you'll also need this change:
>
> --- a/scripts/kconfig/mconf.c
> +++ b/scripts/kconfig/mconf.c
> @@ -773,7 +773,7 @@ static void conf_string(struct menu *menu)
>
> while (1) {
> int res;
> - char *heading;
> + const char *heading;
>
> On a side note, git-diff gives me this error in mconf.c:
>
> @@ -924,4 +924,4 @@ int main(int ac, char **av)
> }
>
> return 0;
> -}
> +}
> \ No newline at end of file
>
> I've never seen it before so I don't know if this is specific to OS X or
> maybe it's my editor.

I did your suggested changes and applied the patch.
Will be pushed out in a minute.

Sam


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/