Re: [PATCH 1/1] DEBUGFS: Fixing name for debug fs

From: Michal Simek
Date: Sun May 04 2008 - 04:55:39 EST


Hi Arnd,

This is question up to PowerPC guys not to me.
of_debugfs_root sounds good.

M


>> This change is made because powerpc_debugfs_root is arch
>> specific name.
> ...
>>
>> static int powerpc_debugfs_init(void)
>> {
>> - powerpc_debugfs_root = debugfs_create_dir("powerpc", NULL);
>> + debugfs_root = debugfs_create_dir("powerpc", NULL);
>>
>
> You left the name as "powerpc", which sort of defeats the purpose of your
> patch. Files in debugfs are by definition not part of the ABI, so it's
> actually possible to change this as well. How about making this "of"
> instead of "powerpc"?
>
> Arnd <><
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/