Re: [PATCH 1/1] DEBUGFS: Fixing name for debug fs

From: Arnd Bergmann
Date: Sat May 03 2008 - 17:07:27 EST


On Saturday 03 May 2008, monstr@xxxxxxxxx wrote:
> From: Michal Simek <monstr@xxxxxxxxx>
>
> This change is made because powerpc_debugfs_root is arch
> specific name.
...
>  
>  static int powerpc_debugfs_init(void)
>  {
> -       powerpc_debugfs_root = debugfs_create_dir("powerpc", NULL);
> +       debugfs_root = debugfs_create_dir("powerpc", NULL);
>  

You left the name as "powerpc", which sort of defeats the purpose of your
patch. Files in debugfs are by definition not part of the ABI, so it's
actually possible to change this as well. How about making this "of"
instead of "powerpc"?

Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/