Re: [PATCH 3/3] OLPC: gxfb/lxfb: add DCON panel modes toframebuffer drivers

[Andrew Morton]

On Mon, 14 Apr 2008 03:53:02 -0400 Andres Salomon <dilinger@xxxxxxxxxx> wrote:

> 
> Since there's no way to autodetect panel modes, we're forced to hardcode
> them in the driver and add a big fat #ifdef.  The OLPC DCON needs a
> specific mode line (at 1200x900).  This adds it to both gxfb and lxfb.
> 
> ...
>
> +static const struct fb_videomode gx_dcon_modedb[] __initdata = {
> +const struct fb_videomode olpc_dcon_modedb[] __initdata = {

include/linux/init.h:38 points out that `const' and `__initdata' should
not be mixed.

I forget which architecture/compiler versions explode when we do this.  But
it's not x86, iirc.

Still, it's poor form and, err, I don't immediately recall which tag we
_should_ use, and the comments in there are unhelpful.  It might be
__initconst, but that has exactly zero users.  Help.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/