Re: [2.6 patch] mfd/sm501.c: #if 0 unused functions

From: Adrian Bunk
Date: Sun Apr 13 2008 - 15:54:36 EST


On Sun, Apr 13, 2008 at 09:34:24PM +0200, Jesper Juhl wrote:
>...
> Please don't see my comments as complaints. They are not intended as
> such. I'm merely currious why we keep adding all these '#if 0's since
> I don't see the point and I can just see them piling up into some huge
> janitorial mountain from hell to be tackled some time in the future by
> whomever is masochistic enough to try ;-)

The main advantage of the #if 0 solution is that it not only stops
bloating the kernel image, but in the frequent "I might need it some day"
case I can simply say "no problem with my patch - just remove the #if 0".

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/