Re: [PATCH] lzo: fix possible typo in decompresor

From: Linus Torvalds
Date: Thu Apr 10 2008 - 16:49:42 EST




On Thu, 10 Apr 2008, Harvey Harrison wrote:
>
> Shift of a le value seems strange, probably meant to shift the cpu-order
> variable as in the prvious section of the switch statement.

Hmm. This patch looks ObviouslyCorrect(tm), but it worries me that
apparently the old broken code has been around since last July, and afaik
it can never have worked on big-endian machines.

So did nobody ever use it, or why hasn't this ever triggered? How did you
find this? A sparse warning?

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/