Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c -take 2

From: Ingo Molnar
Date: Sun Jan 27 2008 - 17:43:22 EST



* Dmitri Vorobiev <dmitri.vorobiev@xxxxxxxxx> wrote:

> Looks like it would be better to proceed in the following manner:
>
> 1) remove dead code (no md5 change);
> 2) reformat the lines to use tabs, not spaces (no md5 change);
> 3) address the "else-braces" and "single statement block" errors
> (no md5 change);
> 4) remove all unnecessary spaces (no md5 change);
> 5) add the KERN_ macros (md5 will change).
> 6) address remaining checkpatch complaints (no md5 change wrt #5
> above).
>
> Each item above might get into a separate patch.

agreed, that looks like a sensible splitup for such larger cleanup
patches.

(also, a debug switch that disabled the FPU on modern CPUs and which
forced math-emu would be nice as well.)

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/