Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c - take 2

From: Paolo Ciarrocchi
Date: Sun Jan 27 2008 - 17:39:18 EST


On Jan 27, 2008 11:32 PM, Dmitri Vorobiev <dmitri.vorobiev@xxxxxxxxx> wrote:
[..]
>
> Is there any point in changing code inside the #if 0/#endif block?

Just to avoid checkpatch complaints :-)

> > @@ -76,10 +74,10 @@ void Un_impl(void)
> > /*
> > Called for opcodes which are illegal and which are known to result in a
> > SIGILL with a real 80486.
> > - */
> > +*/
> > void FPU_illegal(void)
> > {
> > - math_abort(FPU_info,SIGILL);
> > + math_abort(FPU_info, SIGILL);
> > }
> >
> >
> > @@ -88,61 +86,69 @@ void FPU_printall(void)
> > {
> > int i;
> > static const char *tag_desc[] = { "Valid", "Zero", "ERROR", "Empty",
> > - "DeNorm", "Inf", "NaN" };
> > + "DeNorm", "Inf", "NaN" };
>
> Umm... Why?

I'll remove it.

Thanks.

Ciao,
--
Paolo
http://paolo.ciarrocchi.googlepages.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/