Re: 2.6.22-rc1-mm1 cifs_mount oops

[young dave]

Hi,

> Yeah, that's racy: once we've sent the signal, the kernel thread can write
> NULL to srvTcp->tsk at any time.

Yes, here is another patch :

diff -ur linux/fs/cifs/connect.c linux.new/fs/cifs/connect.c
--- linux/fs/cifs/connect.c     2007-05-23 10:59:13.000000000 +0000
+++ linux.new/fs/cifs/connect.c 2007-05-23 15:16:11.000000000 +0000
@@ -650,6 +650,7 @@

       spin_lock(&GlobalMid_Lock);
       server->tcpStatus = CifsExiting;
+       kthread_stop(server->tsk);
       server->tsk = NULL;
       /* check if we have blocked requests that need to free */
       /* Note that cifs_max_pending is normally 50, but
@@ -2070,7 +2071,6 @@
                       spin_unlock(&GlobalMid_Lock);
                       if (srvTcp->tsk) {
                               send_sig(SIGKILL,srvTcp->tsk,1);
-                               kthread_stop(srvTcp->tsk);
                       }
               }
                /* If find_unc succeeded then rc == 0 so we can not end */

Regards
dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/