Re: 2.6.22-rc1-mm1 cifs_mount oops

[Andrew Morton]

On Wed, 23 May 2007 02:59:07 +0000 "young dave" <hidave.darkstar@xxxxxxxxx> wrote:

> Hi,
> maybe we can add if sentence before kthread_stop.
> 
> diff -ur linux/fs/cifs/connect.c linux.new/fs/cifs/connect.c
> --- linux/fs/cifs/connect.c     2007-05-23 10:59:13.000000000 +0000
> +++ linux.new/fs/cifs/connect.c 2007-05-23 10:58:39.000000000 +0000
> @@ -2070,7 +2070,8 @@
>                         spin_unlock(&GlobalMid_Lock);
>                         if (srvTcp->tsk) {
>                                 send_sig(SIGKILL,srvTcp->tsk,1);
> -                               kthread_stop(srvTcp->tsk);
> +                               if(srvTcp->tsk)
> +                                       kthread_stop(srvTcp->tsk);
>                         }
>                 }

Yeah, that's racy: once we've sent the signal, the kernel thread can write
NULL to srvTcp->tsk at any time.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/