Re: [PATCH] x86: limit mwait_idle to Intel CPUs

From: Markus Rechberger
Date: Thu Apr 05 2007 - 13:04:56 EST


H. Peter Anvin wrote:
Andreas Herrmann wrote:

It is not equivalent. Usually users check /proc/cpuinfo for their
CPU features. Deleting that flag is kind of obfuscation.

I guess some time ago people did not care about their "svm" or "vmx"
flags. Nowadays (e.g. with kvm) some people are quite happy
if one of those strings occurs in /proc/cpuinfo (and they are quite
disappointed if this feature was disabled by BIOS).


What you're saying is that you want it to appear in /proc/cpuinfo for marketing reasons even though it's not usable.

The ones in /proc/cpuinfo are cooked values anyway; there is plenty of history to that effect.

I would agree with Andi that if as far as Linux is concerned mwait is unusable on AMD Fam10 processors, then the CPU detection code should turn this bit off on AMD Fam10 processors.

please see:

http://kvm.qumranet.com/kvmwiki/FAQ

"How can I tell if I have Intel VT or AMD-V?"

Markus

--
Markus Rechberger
Operating System Research Center
AMD Saxony LLC & Co. KG



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/