Re: + ocfs2-relative-atime-support-tweaks.patch added to -mm tree

[Mark Fasheh]

On Tue, Dec 05, 2006 at 10:12:45PM -0800, akpm@xxxxxxxx wrote:
> ------------------------------------------------------
> Subject: ocfs2-relative-atime-support-tweaks
> From: Andrew Morton <akpm@xxxxxxxx>
> 
> methinks...
Yeah, all good tweaks - thanks for catching those. And thanks for carrying
the ocfs2 patch in -mm.

Acked-by: Mark Fasheh <mark.fasheh@xxxxxxxxxx>

> diff -puN fs/ocfs2/file.c~ocfs2-relative-atime-support-tweaks fs/ocfs2/file.c
> --- a/fs/ocfs2/file.c~ocfs2-relative-atime-support-tweaks
> +++ a/fs/ocfs2/file.c
> @@ -153,16 +153,15 @@ int ocfs2_should_update_atime(struct ino
>  	    ((vfsmnt->mnt_flags & MNT_NODIRATIME) && S_ISDIR(inode->i_mode)))
>  		return 0;
>  
> -	now = CURRENT_TIME;
> -
>  	if (vfsmnt->mnt_flags & MNT_RELATIME) {
> -		if ((timespec_compare(&inode->i_atime, &inode->i_mtime) < 0) ||
> -		    (timespec_compare(&inode->i_atime, &inode->i_ctime) < 0))
> +		if ((timespec_compare(&inode->i_atime, &inode->i_mtime) <= 0) ||
> +		    (timespec_compare(&inode->i_atime, &inode->i_ctime) <= 0))
>  			return 1;
Hmm, should we fix up touch_atime() to use "<=" as well? Maybe I didn't read
it correctly...
	--Mark

--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@xxxxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/