Re: [PATCH] strstrip remove last blank fix

[Pekka J Enberg]

On Thu, 26 Oct 2006, Michael Holzheu wrote:
> strstrip() does not remove the last blank from strings which only consist
> of blanks.

[snip]

> Acked-by: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> Signed-off-by: Michael Holzheu <holzheu@xxxxxxxxxx>
> 
> ---
> 
>  lib/string.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff -Naurp linux-2.6.18/lib/string.c linux-2.6.18-strstrip-fix/lib/string.c
> --- linux-2.6.18/lib/string.c	2006-06-19 14:03:20.000000000 +0200
> +++ linux-2.6.18-strstrip-fix/lib/string.c	2006-10-25 18:36:08.000000000 +0200
> @@ -320,7 +320,7 @@ char *strstrip(char *s)
>  		return s;
>  
>  	end = s + size - 1;
> -	while (end != s && isspace(*end))
> +	while (end >= s && isspace(*end))
>  		end--;
>  	*(end + 1) = '\0';

Looks good, thanks!  Andrew, can you please pick up this patch?

Acked-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/