Re: [PATCH] bitmap: bitmap_parse takes a kernel buffer instead of auser buffer

From: Paul Jackson
Date: Wed Oct 04 2006 - 11:07:27 EST


Joe wrote:
> I guess I am a sucker for no-transient-buffer (bufferless?)

Ah - that explains Joe's preference for putting the actual implementing
code in the user version - it gets to pull in the user string one
char at a time, avoiding a malloc'd buffer.

I tend to make more coding mistakes that way, so have gotten in the
habit of keeping my scanning code separate from any code required to
get a nice safe local copy of the input that is to be scanned.

I agree with Joe - either way can be made to work - author's
discretion. Just be sure to impose that sanity limit.

--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@xxxxxxx> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/