Re: [NEW PATCH] VIA IRQ quirk behaviour change

From: Stian Jordet
Date: Thu Sep 07 2006 - 17:05:31 EST


tor, 07,.09.2006 kl. 12.43 +0100, skrev Sergio Monteiro Basto:
> the statment was write by Linus on http://lkml.org/lkml/2005/9/27/113
> my patch don't quirk any device if we are working on IO-APIC,
> Linus simply know if a interrupt is > 15 we are working on IO-APIC and
> just don't quirk irq > 15
>
> > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> > > --- a/drivers/pci/quirks.c
> > > +++ b/drivers/pci/quirks.c
> > > @@ -546,7 +546,10 @@ static void quirk_via_irq(struct pci_dev
> > > {
> > > u8 irq, new_irq;
> > >
> > > - new_irq = dev->irq & 0xf;
> > > + new_irq = dev->irq;
> > > + if (!new_irq || new_irq >= 15)
> > > + return;
> > > +
> > > pci_read_config_byte(dev, PCI_INTERRUPT_LINE, &irq);
> > > if (new_irq != irq) {

After a quick test tonight, this patch seems to work nicely for me. (I
know I told Linux that it didn't, don't know what's changed). Does this
fix the problems other people is having as well? If so, that would be
nice :)

Thanks.

-Stian

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/