Re: [patch 50/61] lock validator: special locking: hrtimer.c

From: Andrew Morton
Date: Mon May 29 2006 - 21:31:17 EST


On Mon, 29 May 2006 23:27:09 +0200
Ingo Molnar <mingo@xxxxxxx> wrote:

> From: Ingo Molnar <mingo@xxxxxxx>
>
> teach special (recursive) locking code to the lock validator. Has no
> effect on non-lockdep kernels.
>
> Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
> Signed-off-by: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
> ---
> kernel/hrtimer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux/kernel/hrtimer.c
> ===================================================================
> --- linux.orig/kernel/hrtimer.c
> +++ linux/kernel/hrtimer.c
> @@ -786,7 +786,7 @@ static void __devinit init_hrtimers_cpu(
> int i;
>
> for (i = 0; i < MAX_HRTIMER_BASES; i++, base++)
> - spin_lock_init(&base->lock);
> + spin_lock_init_static(&base->lock);
> }
>

Perhaps the validator core's implementation of spin_lock_init() could look
at the address and work out if it's within the static storage sections.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/