Re: [PATCH 2/2] list: use list_replace_init() instead oflist_splice_init()

From: David S. Miller
Date: Wed May 17 2006 - 18:46:52 EST


From: Oleg Nesterov <oleg@xxxxxxxxxx>
Date: Thu, 18 May 2006 05:40:42 +0400

> list_splice_init(list, head) does unneeded job if it is known that
> list_empty(head) == 1. We can use list_replace_init() instead.
>
> [ I did list_replace() for use in kernel/timer.c. I am not sure it
> is ok to patch random files at once, but it looks so simple ... ].
>
> arch/i386/mm/pageattr.c | 8 ++++----
> block/ll_rw_blk.c | 5 ++---
> fs/aio.c | 4 ++--
> kernel/timer.c | 8 ++++----
> kernel/workqueue.c | 4 ++--
> net/core/dev.c | 6 +++---
> net/core/link_watch.c | 5 ++---
> 7 files changed, 19 insertions(+), 21 deletions(-)
>
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/