Re: [PATCH] fix mem-leak in netfilter

From: Jesper Juhl
Date: Fri May 12 2006 - 08:13:15 EST


On 5/12/06, Patrick McHardy <kaber@xxxxxxxxx> wrote:
Jesper Juhl wrote:
> On 5/12/06, Patrick McHardy <kaber@xxxxxxxxx> wrote:
>
>> I haven't seen any cleanup patches so far, so I think I'm
>> going to start my nth try at cleaning up this mess.
>> Unfortunately its even immune to Lindent ..
>>
>
> If you get too fed up with it, let me know, and I'll give it a go as well.

Thanks, I'm about half-way through (and about to kill someone),
just started with the biggest pile of crap (the match function)
and already noticed a possible endless loop within the first
couple of lines.

Unfortunately this stuff is so unreadable that I'm not exactly
sure if the loop really won't terminate, an extra pair of eyes
would be appreciated.


Sure thing.

I don't have time to look at it today (friends comming over for
dinner), but I should have plenty of time for it tomorrow. So, if you
could send me your patch once you are done for the day, then I'll look
it over and see if I can find anything to add on top of your work (or
have anything to comment on) and bounce it back to you sometime during
tomorrow.


--
Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/