Re: [PATCH] ide_cs: Make ide_cs work with the memory space ofCF-Cards if IO space is not available

From: Alan Cox
Date: Thu May 11 2006 - 11:40:17 EST


On Iau, 2006-05-11 at 04:10 +0200, Thomas Kleffel (maintech GmbH) wrote:
> From: Thomas Kleffel <tk@xxxxxxxxxxx>
>
> this patch enables ide_cs to access CF-cards via their common memory
> rather than via their IO space.

One obvious problem. Your patch simply sets io_base to an ioremap value.
The ide_cs code assumes port accesses (eg it does outb() on base + 2).
While outb() may happen to work on ARM on ioremap returns it doesn't on
most platforms.

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/