Re: [PATCH 2/5] Swapless V2: Add migration swap entries

[Andrew Morton]

Christoph Lameter <clameter@xxxxxxx> wrote:
>
> On Thu, 13 Apr 2006, Andrew Morton wrote:
> 
> > Christoph Lameter <clameter@xxxxxxx> wrote:
> > >
> > > +
> > >  +	if (unlikely(is_migration_entry(entry))) {
> > 
> > Perhaps put the unlikely() in is_migration_entry()?
> > 
> > >  +		yield();
> > 
> > Please, no yielding.
> > 
> > _especially_ no unchangelogged, uncommented yielding.
> 
> Page migration is ongoing so its best to do something else first.

That doesn't help a lot.  What is "something else"?  What are the dynamics
in there, and why do you feel that some sort of delay is needed?

> Add a comment?

I don't think we're up to that stage yet.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/