Re: [PATCH 2/5] Swapless V2: Add migration swap entries
From: Christoph Lameter
Date: Thu Apr 13 2006 - 20:30:11 EST
On Thu, 13 Apr 2006, Andrew Morton wrote:
> Christoph Lameter <clameter@xxxxxxx> wrote:
> >
> > +
> > + if (unlikely(is_migration_entry(entry))) {
>
> Perhaps put the unlikely() in is_migration_entry()?
>
> > + yield();
>
> Please, no yielding.
>
> _especially_ no unchangelogged, uncommented yielding.
Page migration is ongoing so its best to do something else first.
Add a comment?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/