Re: SMP BUG

From: Russell King
Date: Wed Feb 15 2006 - 18:35:08 EST


On Wed, Feb 15, 2006 at 03:30:13PM -0800, Andrew Morton wrote:
> Linus Torvalds <torvalds@xxxxxxxx> wrote:
> > That said, nobody seemed to comment on this patch by Rik, which seemed to
> > be a nice cleanup regardless of any other issues.
>
> I thought that patch wasn't a good one. The runqueues should be
> initialised in sched_init(). init_idle() is called from fork_idle() which
> is called from the bowels of arch code. I'm not sure that it gets called
> at all if !SMP (which seems strange).

Wouldn't it make sense to do this initialisation in a CPU_UP_PREPARE
notifier, if not already done?

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/