Re: noisy edac

From: doug thompson
Date: Tue Jan 31 2006 - 11:33:31 EST


On Mon, 2006-01-30 at 20:15 -0800, Dave Peterson wrote:
> On Monday 30 January 2006 19:22, Eric W. Biederman wrote:
> > One piece missing from this conversation is the issue that we need errors
> > in a uniform format. That is why edac_mc has helper functions.
> >
> > However there will always be errors that don't fit any particular model.
> > Could we add a edac_printk(dev, ); That is similar to dev_printk but
> > prints out an EDAC header and the device on which the error was found?
> > Letting the rest of the string be user specified.
>
> I like this idea. It would facilitate grepping in logfiles for
> EDAC-related errors.

Yes, eric, that puts into words what I was trying to express.

Refactor all the MC drivers to utilize such a 'edac_printk()' helper
function, and add control mechanisms to that function for level of
output, etc. Then the begining format of the output stream can be
"tagged" as EDAC output, etc, for harvest patterns.

As to Dave Jones original, I remember that the "NON-FATAL" tag was still
indicating that some error was occuring, but it wasn't a "take the
machine down" type of event. But it was some problem. Time to break out
the Intel Specs for that MC.

doug t


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/