Re: [PATCH 2/11] LED: Add LED Class

[Jan-Benedict Glaw]

On Tue, 2006-01-31 13:41:28 +0000, Richard Purdie <rpurdie@xxxxxxxxx> wrote:
> Index: linux-2.6.15/include/linux/leds.h
> ===================================================================
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ linux-2.6.15/include/linux/leds.h	2006-01-29 16:03:21.000000000 +0000
> +enum led_brightness {
> +	LED_OFF = 0,
> +	LED_HALF = 127,
> +	LED_FULL = 255,
> +};
> +
> +struct led_device {
> +	/* A function to set the brightness of the led */
> +	void (*brightness_set)(struct led_device *led_dev, enum led_brightness brightness);

I somehow dislike using an enum being abused for a dimmed LED value...

MfG, JBG

-- 
Jan-Benedict Glaw       jbglaw@xxxxxxxxxx    . +49-172-7608481             _ O _
"Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg  _ _ O
 fÃr einen Freien Staat voll Freier BÃrger"  | im Internet! |   im Irak!   O O O
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));

Attachment: signature.asc
Description: Digital signature