Re: [PATCH 10/11] LED: Add IDE disk activity LED trigger

From: Bartlomiej Zolnierkiewicz
Date: Tue Jan 31 2006 - 09:49:07 EST


Hi,

Why cannot existing block layer hook be used for this?

Why are you adding LED_FULL event handling to a specific
device driver (ide-disk) but LED_OFF event handling to a generic
IDE end request function?

This solution has very limited flexibility (disk accesses for
all IDE ports will be registered as coming from the same
source) but I guess it is fine?

Thanks,
Bartlomiej

On 1/31/06, Richard Purdie <rpurdie@xxxxxxxxx> wrote:
> Add an LED trigger for IDE disk activity to the IDE subsystem.
>
> Signed-off-by: Richard Purdie <rpurdie@xxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/