Re: [PATCH] pepoll_wait ...

[Davide Libenzi]

On Tue, 17 Jan 2006, Ulrich Drepper wrote:

> Davide Libenzi wrote:
> > The attached patch implements the pepoll_wait system call, that extend
> > the event wait mechanism with the same logic ppoll and pselect do. The
> > definition of pepoll_wait is: [...]
>
> I definitely ACK this patch, it's needed for the same reasons we need
> pselect and ppoll.
>
>
> > +	if (error == -EINTR) {
> > +		if (sigmask) {
> > +			memcpy(&current->saved_sigmask, &sigsaved, sizeof(sigsaved));
> > +			set_thread_flag(TIF_RESTORE_SIGMASK);
> > +		}
> > +	} else if (sigmask)
> > +		sigprocmask(SIG_SETMASK, &sigsaved, NULL);
>
> This part I'd clean up a bit, though.  Move the if (sigmask) test to the
> top and have the EINTR test decide what to do.  As is the code would be
> a bit irritating if it wouldn't be so trivial.  The important thing is
> that you only do something special if sigmask != NULL.

Agreed.


- Davide


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/