Re: [PATCH 2 of 2] __raw_memcpy_toio32 for x86_64

From: Bryan O'Sullivan
Date: Wed Jan 11 2006 - 23:31:17 EST


On Thu, 2006-01-12 at 05:19 +0100, Andi Kleen wrote:

> My feeling is more and more that this thing is so specialized for your setup
> and so narrow purpose that you're best off dropping this whole patchkit and
> just put the assembly into your driver.

But this gave people fits when Roland first posted the driver for
review. There's also no clean, obvious way to make it work on other
64-bit architectures, in that case.

I don't mind switching the movsq to a movsd, if that's the main aspect
of what you're worried about now, so that it is absolutely a 32-bit
copy.

<b



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/