Re: [PATCH 2 of 2] __raw_memcpy_toio32 for x86_64

From: Andi Kleen
Date: Wed Jan 11 2006 - 23:19:10 EST


On Thursday 12 January 2006 05:14, Bryan O'Sullivan wrote:

> > That sounds like a very chipset specific assumption. Is that safe
> > to make?
>
> I can fix the doc so that it says "at least 32 bits", in that case.
> This should make the assumption more clear for other bus types.

Well it seems quite wrong - an iowrite32 shouldn't write more than 32bits
at a time.

My feeling is more and more that this thing is so specialized for your setup
and so narrow purpose that you're best off dropping this whole patchkit and
just put the assembly into your driver. At least normal kernels wouldn't be
bloated with such unlikely to be useful for anything else functions then.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/