RE: [Patch] es7000 broken without acpi

[Protasevich, Natalie]

> "Protasevich, Natalie" <Natalie.Protasevich@xxxxxxxxxx> wrote:
> >
> > > Eric Sesterhenn / snakebyte <snakebyte@xxxxxx> wrote:
> >  > >
> >  > > hi,
> >  > >
> >  > > a make randconfig gave me a situation where es7000 was 
> enabled, 
> > but  > > acpi wasnt ( dont know if this makes sense ), gcc gave me 
> > some  > > compiling errors, which the following patch 
> fixes. Please  > 
> > cc me as i am not on the list. Thanks.
> >  > >
> >  > >
> >  >
> >  > I believe that es7000 requires ACPI, so a better fix 
> would be  > to 
> > enforce that within Kconfig.
> >  >
> >  > Natalie, can you please comment?
> > 
> > 
> >  You are correct, Andrew: ES7000 "preferred" mode is ACPI 
> (although it  
> > runs in MPS as well, which we use for debugging of 
> intermittent ACPI 
> > and  platform problems).
> >  I have done a similar patch (see
> >  http://bugzilla.kernel.org/attachment.cgi?id=5771&action=view) 
> > against  2.6.13, but the one suggested later by Peter Hagervall  
> > http://www.ussg.iu.edu/hypermail/linux/kernel/0510.3/1302.html was  
> > actually taking care of the compile problem through Kconfig 
> better,  
> > since "acpi=off" option is available for our debug/testing 
> purposes  
> > anyway.
> 
> hm, OK.  I won't apply anything then - please send me your 
> preferred fix if you think there's something here which needs 
> fixing.  Either way, we should attempt to make the kernel 
> compile with all possible configs, if only to keep `make 
> randconfig' testers happy ;)

Sure, I will go though the code and make sure to cover all of them :)
--Natalie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/