Re: [PATCH] pci_ids: cleanup comments

From: Greg KH
Date: Wed Oct 19 2005 - 16:47:41 EST


On Wed, Oct 19, 2005 at 02:35:25PM -0700, Roland Dreier wrote:
> I don't think I like this. I prefer the format
>
> #define PCI_DEVICE_ID_NEC_CBUS_1 0x0001 /* PCI-Cbus Bridge */
>
> to taking two lines like
>
> /* PCI-Cbus Bridge */
> #define PCI_DEVICE_ID_NEC_CBUS_1 0x0001
>
> If some script can't handle the first format then I think the script
> should be fixed.

I agree, comments like this belong on the right hand side, it's cleaner
that way.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/